From a7ec70bf3f71b9aae965bd3b6eaa1a3226ea5370 Mon Sep 17 00:00:00 2001 From: m-aXimilian Date: Sat, 14 Jun 2025 16:55:45 +0200 Subject: [PATCH] code review --- lib/utilities/SpdLogger.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/utilities/SpdLogger.cpp b/lib/utilities/SpdLogger.cpp index b383ed9..fa7430f 100644 --- a/lib/utilities/SpdLogger.cpp +++ b/lib/utilities/SpdLogger.cpp @@ -5,7 +5,6 @@ #include #include -#include #include #include "ILog.hpp" @@ -51,31 +50,27 @@ void SpdLogger::ChangeLevel(LogLevel lvl) case LogLevel::Trace: this->logger_->set_level(spdlog::level::trace); spdlog::flush_on(spdlog::level::trace); - st << "Trace"; break; case LogLevel::Info: this->logger_->set_level(spdlog::level::info); spdlog::flush_on(spdlog::level::info); - st << "Info"; break; case LogLevel::Warn: this->logger_->set_level(spdlog::level::warn); spdlog::flush_on(spdlog::level::warn); - st << "Warn"; break; case LogLevel::Error: this->logger_->set_level(spdlog::level::err); spdlog::flush_on(spdlog::level::err); - st << "Error"; break; case LogLevel::Debug: default: this->logger_->set_level(spdlog::level::debug); spdlog::flush_on(spdlog::level::debug); - st << "Debug"; } // you will only get this message for log levels <= info! I.e., not for error or warning. this->logger_->info( - std::format("{}: Changed log level to {}({})", __FUNCTION__, LogLevelToString(lvl), static_cast(lvl))); + std::format("{}: Changed log level to {}({})", __FUNCTION__, LogLevelToString(lvl), static_cast(lvl)) + .c_str()); }