max/pixelarium
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename UpdateResouce to ModifyResource (#4)

Browse Source 
For some reason it seems as if UpdateResource is already defined in
some (other) dependency of Pixelarium.
Instead of throwing around platform specific macros to fix the Windows
build for correct mangling, I decided to simply rename the function.

Fixes #3
This commit is contained in:
m-aXimilian
2025-07-28 08:46:16 +00:00
committed by GitHub
parent f9b55796ce
commit 566dd112ff
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/lib/resources/test_resource.cpp
+4 -4
View File
@@ -43,22 +43,22 @@ TEST(ImageResourcePoolTest, GetNonExistentResourceReturnsEmptyOptional)
EXPECT_FALSE(pool.GetResource(12345));
}
TEST(ImageResourcePoolTest, UpdateResourceSuccess)
TEST(ImageResourcePoolTest, ModifyResourceSuccess)
{
ImageResourcePool pool;
auto id = pool.SetResource(std::make_unique<DummyImage>());
auto new_img = std::make_unique<DummyImage>();
EXPECT_TRUE(pool.UpdateResource(id, std::move(new_img)));
EXPECT_TRUE(pool.ModifyResource(id, std::move(new_img)));
auto res = pool.GetResource(id);
EXPECT_TRUE(res.has_value());
EXPECT_NE(res.value(), nullptr);
}
TEST(ImageResourcePoolTest, UpdateResourceFail)
TEST(ImageResourcePoolTest, ModifyResourceFail)
{
ImageResourcePool pool;
auto new_img = std::make_unique<DummyImage>();
EXPECT_FALSE(pool.UpdateResource(999, std::move(new_img)));
EXPECT_FALSE(pool.ModifyResource(999, std::move(new_img)));
}
TEST(ImageResourcePoolTest, DeleteResourceSuccess)